Skip to content

Conversation

@grindtildeath
Copy link
Contributor

…tion

@OCA-git-bot
Copy link
Contributor

Hi @hparfr, @sebastienbeau,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor remark only.

filter_domain = fields.Char(
string="Apply on records",
default="[]",
help="If present, this condition must be satisfied to trigger the exception.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help="If present, this condition must be satisfied to trigger the exception.",
help="If present, this condition must be satisfied to trigger the exception, no matter the Exception type.",

Copy link
Contributor

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Can you explain why / how to use in the usage.md.

I guess it's a kind of a pre-filter to skip the test of exception on some records. Is it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants